Skip to content

feat: agent-deck session approve command for Codex approval prompts#1566

Open
Juoper wants to merge 3 commits into
asheshgoplani:mainfrom
Juoper:codex/session-approve
Open

feat: agent-deck session approve command for Codex approval prompts#1566
Juoper wants to merge 3 commits into
asheshgoplani:mainfrom
Juoper:codex/session-approve

Conversation

@Juoper

@Juoper Juoper commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a prompt-aware command for resolving Codex approval menus without treating the selected option as composer text.

session send <id> "1" sends text followed by Enter. Codex approval menus consume the digit as an immediate key event, so the delayed Enter can land in the resumed turn or the digit can be submitted to the normal composer when prompt state races.

The new command detects and revalidates a live numbered approval menu, sends exactly one option key, verifies that the original prompt clears, and never retries the approval blindly.

Syntax

agent-deck session approve <id|title> [once|always|session|N]

Examples:

agent-deck session approve worker
agent-deck session approve worker always
agent-deck session approve worker 2 --json

Validation

  • go test ./internal/send -run 'CodexApproval'
  • go test ./cmd/agent-deck -run '^$'
  • go test ./internal/session -run 'TestBridgeTemplate|TestConductor.*Template|TestConductorPrompt'

@coderabbitai

coderabbitai Bot commented Jul 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Review limit reached

@asheshgoplani, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 1 minute

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 66a89a9c-ba1d-4666-a335-ebf9bc4e2272

📥 Commits

Reviewing files that changed from the base of the PR and between 10189df and 5786ff7.

⛔ Files ignored due to path filters (5)
  • CHANGELOG.md is excluded by !**/*.md, !CHANGELOG.md
  • conductor/conductor-claude.md is excluded by !**/*.md
  • conductor/conductor-hermes.md is excluded by !**/*.md
  • skills/agent-deck/references/cli-reference.md is excluded by !**/*.md
  • skills/fleet/SKILL.md is excluded by !**/*.md
📒 Files selected for processing (5)
  • cmd/agent-deck/session_approve_cmd.go
  • cmd/agent-deck/session_cmd.go
  • internal/send/codex_approval.go
  • internal/send/codex_approval_test.go
  • internal/session/conductor_templates.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@asheshgoplani
fix(approve): keep Codex prompt verification fail-closed
643cb51 
Committed by Ashesh Goplani
@asheshgoplani
Merge main into Codex approval command
5786ff7 
Committed by Ashesh Goplani

# Conflicts:
#	CHANGELOG.md
@asheshgoplani asheshgoplani marked this pull request as ready for review July 12, 2026 18:36
@asheshgoplani asheshgoplani self-requested a review as a code owner July 12, 2026 18:36
@asheshgoplani

asheshgoplani commented Jul 12, 2026

Copy link
Copy Markdown
Owner

Maintainer validation is complete and this draft is now ready for review. I refreshed it onto current main and added two fail-closed regressions: multi-digit menu options are rejected because the command promises exactly one keypress, and moving the menu highlight no longer counts as the original prompt clearing. All Codex approval tests, CLI compilation, conductor template tests, and sandboxed go build ./... pass locally. The original contribution and authorship remain intact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asheshgoplani asheshgoplani Awaiting requested review from asheshgoplani asheshgoplani is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Juoper @asheshgoplani